-
Notifications
You must be signed in to change notification settings - Fork 10.4k
Workers react framework guide #20214
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Workers react framework guide #20214
Conversation
|
Howdy and thanks for contributing to our repo. We review internal PRs within 1 week. If it's something urgent or has been sitting without a comment, start a thread in the Developer Docs space internally. |
|
Preview URL: https://03998e9e.preview.developers.cloudflare.com Files with changes (up to 15) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good for people getting started. Approved pending the C3 template landing and the links being updated.
There is also a class of people who already have React/Vite projects who would like to deploy to Cloudflare. Do we have a format for migrating frameworks to Cloudflare?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hyperlint Review is complete!
Hyperlint Vale Style Guide Review
Reviewed 1 files and found 1 issues.
See the inline comments and suggestions below.
Hyperlint Link Check Review
Reviewed 1 files and found 0 issues.
We are upgrading our reviewer model! Going forward, our model will learn your particular style - which comments you all accept and reject, so that it can further personalize its suggestions.
What is Hyperlint?
Hyperlint is an AI agent that helps you write, edit, and maintain your documentation. It can review, edit, and suggest fixes for your documentation.
Learn more about the Hyperlint AI reviewer and the checks that we can run on your documentation.
@petebacondarwin I left you some inline questions. Once those are resolved, will this be ready to merge? (I ask because I see that your template is merged, but the original template this was created for isn't merged, and I'm not sure what the difference is. To answer your question about migrating existing frameworks. That's a content gap we need to fill in. Is the process essentially the same for each framework guide? If so, we can create a "Migrate your existing project" partial and add it to each guide? If that sounds like the right approach, I think it would make sense to create that as a separate follow-up PR. Let me know. Thanks! |
Yes this docs update looks ready to merge once we resolve those two inline comments.
|
@petebacondarwin Updated! |
|
I have a PR up to graduate the Workers C3 template from experimental: cloudflare/workers-sdk#8371 |
Co-authored-by: Maddy <[email protected]>
@petebacondarwin Just to clarify - I should hold off on merging this until that lands? |
If it is ready to merge now, you can go ahead. I am going to merge the workers-sdk change now. But it will probably not be released until Tuesday now. So we can have a new PR for then. |
|
Oh it seems we are going to release the workers-sdk changes today. So let's hold on merging this and fix it up to match the non-experimental C3 template. |
WIP
Fixes #19653